search

Albert-Gao / modern-es6-npm-boilerplate

An ES6 boilerplate for writing NPM package.
MIT License
43 stars 4 forks source link

Add coverage support #8

Closed vaibhavmule closed 7 years ago

vaibhavmule commented 7 years ago

We already have coverage folder ignored in .gitignore

A coverage report is shown in terminal and written to ./coverage when you run npm run coverage

image

Albert-Gao commented 7 years ago

If we go to the separate command, I'd like to use coverage, 'cos I think it's clear.

And I think it might be better if we just update the doc to let people know that they can use npm run test -- --coverage, because if we go to npm run coverage, it's really testing and collecting coverage, a little bit duplicate to me.

What do you think? :)

But still It's a little bit strange that it failed the check. I tried to re-run, but still the same. Maybe encoding?

vaibhavmule commented 7 years ago

Yeah I had same feeling, the duplication part. Lets go with this npm run test -- --coverage.

Travis, yesterday there was an issue with Travis I saw on their status page, anyways