AlbertBrand / react-native-android-tablayout

React Native Android TabLayout native component
140 stars 29 forks source link

Not installing correctly in node4.4.6 ubuntu 14.04 #25

Open ashutosh-akss opened 8 years ago

ashutosh-akss commented 8 years ago

Getting following error in installation node v4.4.6 npm v3.10.3

+-- UNMET PEER DEPENDENCY react-native@0.29.0
`-- react-native-android-tablayout@0.3.0 

npm WARN react-native-android-tablayout@0.3.0 requires a peer of react-native@0.28 but none was installed.
elijahverdoorn commented 8 years ago

This needs to be updated to React-Native 0.29.0. Mentioning @AlbertBrand in hopes of an update.

AlbertBrand commented 8 years ago

True, I should've used an upward dep. It's only a warning though.

elijahverdoorn commented 8 years ago

For sure. Not a big deal, but throwing it in a future update wouldn't hurt. Thanks!

hawkrives commented 8 years ago

@AlbertBrand: Would you mind a PR to switch it to either a list of versions or a >= dependency? It's just a warning, but I see it a lot… 😄

I love the library, too. It's given us no problems thus far!