Update indicesOf.js - Githubissues

AlbertLucianto / vue-text-highlight

Text highlighter library for Vue.js :lipstick:

https://albertlucianto.github.io/vue-text-highlight

MIT License

326 stars 35 forks source link

Update indicesOf.js #15

Closed EvanHildebrandt closed 5 years ago

EvanHildebrandt commented 5 years ago

Update indicesOf to respect RegExp Fixes #14

AlbertLucianto commented 5 years ago

Hi @EvanHildebrandt, thank you for raising the issue and creating this PR, this fix works great!

Before I merge this, can you help with these two things:

Try running yarn test or npm run test, and update failing test cases.
Fix linter errors in your changes in src.

EvanHildebrandt commented 5 years ago

Thanks for the reply! Had some git config issues between my work/home computers. That test should be good to go now. Just removed the duplicated indices caused by the original bug.

AlbertLucianto commented 5 years ago

This PR is included in version 2.0.8 :tada: