search

AlbertLucianto / vue-text-highlight

Text highlighter library for Vue.js :lipstick:
https://albertlucianto.github.io/vue-text-highlight
MIT License
326 stars 35 forks source link

add wholeWordMatch option to select only the whole word #38

Closed ntedgi closed 4 years ago

ntedgi commented 4 years ago

a before and after Usage example

before after closes #37

ntedgi commented 4 years ago

Hi @AlbertLucianto ! Do you think this feature is usable? are you going to merge it ? or should I use my own fork inside my projects?

AlbertLucianto commented 4 years ago

Hi @ntedgi, thanks a lot for the MR, this is certainly useful. Sorry for the delay, it's been quite busy with the office work. I'll try reviewing it after office hours.

AlbertLucianto commented 4 years ago

Hi @ntedgi, as you might notice, it's been a while since I maintained and published a new version of this library. And it's quite strange that the rollup failed to build (doesn't output anything). I tried briefly to figure out the issue, still can't fix it.

Do you mind helping me to find the cause, or might as well upgrade the rollup and plugins versions? I'm still quite busy with the office work 😅 really appreciate for your help.

ntedgi commented 4 years ago

No problem Il take a look , what is the new version you want to assign to master ? 2.1.0 or 2.0.11?

On Thu, 17 Sep 2020 at 17:26 Albert Lucianto notifications@github.com wrote:

Hi @ntedgi https://github.com/ntedgi, as you might notice, it's been a while since I maintained and published a new version of this library. And it's quite strange that the rollup failed to build (doesn't output anything). I tried briefly to figure out the issue, still can't fix it.

Do you mind helping me to find the cause, or might as well upgrade the rollup and plugins versions? I'm still quite busy with the office work 😅 really appreciate for your help.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AlbertLucianto/vue-text-highlight/pull/38#issuecomment-694272742, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHOL4ENQZVMUXUHIVNETKCTSGIL7XANCNFSM4RKUOKDQ .

AlbertLucianto commented 4 years ago

Should be 2.1.0. Thanks a lot for the help!

ntedgi commented 4 years ago

npm notice npm notice 📦 vue-text-highlight@2.1.0 npm notice === Tarball Contents === npm notice 1.1kB LICENSE
npm notice 4.0kB package.json
npm notice 1.4kB CHANGELOG.md
npm notice 5.2kB README.md
npm notice === Tarball Details === npm notice name: vue-text-highlight
npm notice version: 2.1.0
npm notice package size: 5.7 kB
npm notice unpacked size: 18.2 kB
npm notice shasum: 4c71c8ec8196e22611134e8cfc394df1b679cc92 npm notice integrity: sha512-4zx+XxSer3dpH[...]UmSzHW9oIw0sg== npm notice total files: 5
npm notice npm ERR! code E403 npm ERR! 403 403 Forbidden - PUT https://registry.npmjs.org/vue-text-highlight - You do not have permission to publish "vue-text-highlight". Are you logged in as the correct user?

sorry I don't have permission you need to change it from your account follow this steps run npm login enter npm user name password and github mail ' then run npm publish

AlbertLucianto commented 4 years ago

Can you try running yarn build and see if there's output in the dist folder? Supposedly it outputs build files like vue-text-highlight.min.js, but now there's nothing outputted, only the demo build by webpack.

By the way, I'm using macOS Catalina, node 8.17.0, and 10.22.0.

Shonetow commented 4 years ago

This is not yet available, right?

ntedgi commented 4 years ago

Its available in the repo but not published to npm

On Wed, 4 Nov 2020 at 13:25 Nenad Novkovic notifications@github.com wrote:

This is not yet available, right?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AlbertLucianto/vue-text-highlight/pull/38#issuecomment-721675932, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHOL4EJA2BZPHE23XJAXY7DSOE2Y5ANCNFSM4RKUOKDQ .

dili021 commented 3 years ago

Will it be any time soon?

Its available in the repo but not published to npm … On Wed, 4 Nov 2020 at 13:25 Nenad Novkovic @.***> wrote: This is not yet available, right? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#38 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHOL4EJA2BZPHE23XJAXY7DSOE2Y5ANCNFSM4RKUOKDQ .

ntedgi commented 3 years ago

Can you try running yarn build and see if there's output in the dist folder? Supposedly it outputs build files like vue-text-highlight.min.js, but now there's nothing outputted, only the demo build by webpack.

By the way, I'm using macOS Catalina, node 8.17.0, and 10.22.0.

tested on Linux Mint 20. after the build only web dir is created there isn't any *.min.js files