AlbertMN / AssistantComputerControl

Control your computer with your Google Home or Amazon Alexa assistant!
MIT License
879 stars 61 forks source link

[v1.4.5] ALPHA FEEDBACK #115

Closed AlbertMN closed 2 years ago

AlbertMN commented 3 years ago

Testing needed for v1.4.5. hotfix update

All discussion about the possible fixes & changes in this update should be discussed here.

What needs testing;

Download; ACCsetup.zip (unzip and install, will override your current ACC version)

AlbertMN commented 3 years ago

Most likely won't be able to work on ACC again before next week, so hope this can gather some feedback meanwhile, so I can have some stuff to fix.

minhe7735 commented 3 years ago

Screenshot_20211010-195517 Screenshot_20211010-195455 The ifttt applet I use for open_any for reference, which is the main reason why I made made open_any. To use a single applet only.

yummy-ja commented 3 years ago

Hello, I've been testing v1.4.5, specifically in regards to the item "PowerShell window on startup #107". I was having this issue so I installed the update to test. During the uninstall it was unable to automatically close AssistantComputerControl.exe and I had to manually end it from Task Manager. After rebooting the the PowerShell window no longer shows after log in, so it seems the issue has been resolved. However I did check the logs and its still reporting an access denied error for the Windows Task Scheduler:

2021-11-04 00:13:09.3897|DEBUG|AssistantComputerControl.MainProgram|Other ACC instance was running. Killed it. 2021-11-04 00:13:09.3897|DEBUG|AssistantComputerControl.MainProgram|[ACC begun (v1.4.5)] 2021-11-04 00:13:09.4438|DEBUG|AssistantComputerControl.MainProgram|Deleting all files in action folder 2021-11-04 00:13:09.4438|DEBUG|AssistantComputerControl.MainProgram|Old action files removed - moving on... 2021-11-04 00:13:09.4438|DEBUG|AssistantComputerControl.MainProgram|Checking for updates... 2021-11-04 00:13:09.4438|DEBUG|AssistantComputerControl.MainProgram| [AssistantComputerControl] Initiated. Listening in: "C:\Users\jaker\OneDrive\AssistantComputerControl" for ".txt" extensions 2021-11-04 00:13:09.5258|DEBUG|AssistantComputerControl.MainProgram|Failed to create / update cleanup Task Scheduler service; Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED)) 2021-11-04 00:13:10.2465|DEBUG|AssistantComputerControl.MainProgram|Software up to date 2021-11-04 00:13:24.1080|DEBUG|AssistantComputerControl.MainProgram|Failed to create startup task. Defaulting to starting with Windows registry. Exception was; Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED)), trace; + at Microsoft.Win32.TaskScheduler.V2Interop.ITaskFolder.RegisterTaskDefinition(String Path, ITaskDefinition pDefinition, Int32 flags, Object UserId, Object password, TaskLogonType LogonType, Object sddl) at Microsoft.Win32.TaskScheduler.TaskFolder.RegisterTaskDefinition(String path, TaskDefinition definition, TaskCreation createType, String userId, String password, TaskLogonType logonType, String sddl) at Microsoft.Win32.TaskScheduler.TaskFolder.RegisterTaskDefinition(String path, TaskDefinition definition) at AssistantComputerControl.MainProgram.SetStartup(Boolean status, Boolean setThroughSoftware) 2021-11-04 00:13:24.1080|DEBUG|AssistantComputerControl.MainProgram|ACC now starts with Windows (Registry)

I'm running Windows 11 Pro, 21H2

federicosammartin commented 3 years ago

Hi i installed the alpha for the fix on the powershell window opening, but kaspersky flags it as malware it didn't happen with the previous version

AlbertMN commented 3 years ago

@federicosammartin could be because it's a dev. build, but could also just be that the download source is less known. Think the ACC website is starting to be trusted by the "malware" sniffers, but just guesses.

AlbertMN commented 2 years ago

Version is out. Thanks for feedback.