search

AlbertoElias / gulp-lintspaces

Gulp plugin for node-lintspaces. Fork of removed gulp-lintspaces
MIT License
12 stars 9 forks source link

Improve reporter #8

Closed localjo closed 8 years ago

localjo commented 8 years ago

This improves the reporter so that the stream isn't broken on the first linter warning (it lints all files in the stream before throwing an error). It also adds breakOnWarning and prefixLogs options (both default to false) which allow control over whether linting warnings should throw an error, and whether log lines should be prefixed with [gulp-lintspaces]. Along with these changes, the formatting is also improved. Here are some screenshots; screen shot 2016-01-28 at 2 40 23 pm screen shot 2016-01-28 at 2 41 55 pm

localjo commented 8 years ago

Fixes #5

AlbertoElias commented 8 years ago

Sorry for the delay! I've been very busy. Thanks a lot for this. I just left a couple very minor comments. I'll merge it after they're fixed :)

localjo commented 8 years ago

Thanks @AlbertoElias. I force pushed an amended commit with your suggested changes. Should be good to go. By the way, I tried running make test, but it seems like the tests are failing in the master branch, so I'm not sure what the state of the tests is. That's probably a separate issue.

AlbertoElias commented 8 years ago

I'm not sure about the tests either as this is a fork and I haven't really had time to properly fix it up. I'll merge, thanks a lot!