search

AlbertoPdRF / root-file-viewer

View ROOT files directly in VS Code!
https://marketplace.visualstudio.com/items?itemName=albertopdrf.root-file-viewer
MIT License
47 stars 5 forks source link

Windows with long names have hidden minimize/maximize/close buttons #21

Closed schwas3 closed 2 years ago

schwas3 commented 2 years ago

I love using this extension for debugging and there are quite long branch names involved and I have found that the wrapping (at least so I believe) prioritizes the window name over these three buttons, making it hidden completely or barely visible (functionally limiting the size of the button to a very small height). Since there is no right click and close or shortcut to close this can be a bit of a time waster, having to click the window bar and hope the "close" button becomes visible just so I can grab the very small region (another process that isn't all that easy) just to closer a window. By increasing the width of the window so that the entire name fits, it resolves the problem. A fix in one of the future releases would be great! Thanks for developing this extension!

image

image

image

schwas3 commented 2 years ago

User-workaround: right click in the background (i.e. outside of the space of any of the open windows) and select to minimize all, you should now be able to select to close windows easily (this is because it makes them horizontally the length of the viewer so the close option appears (so I believe)

EDIT: this is pretty good but doesn't work for ALL scenarios

AlbertoPdRF commented 2 years ago

Hi @schwas3!

Thanks for filling the issue! Could you please check if this is still a problem with v1.0.0?

schwas3 commented 2 years ago

@AlbertoPdRF I'd say this issue no longer applies to v1.0.0, here is what long branch name handling looks like now:

image

One thing I will note as I close this issue, is that having more than one canvas open is not possible and it is not possible to split VSCode windows to open a second instance of the same .root file, so even that does not allow for such interaction. Also there is a new issue I am going to create about the "Enlarge Canvas" functionality but that is not relevant to this issue...

AlbertoPdRF commented 2 years ago

You cannot open more than one canvas because the default layout has been changed back to tabs, which is the one that has always been the default except for v0.7.0 and v0.8.0. You can go back to the flex layout by adjusting the relevant extension setting if you prefer it :slightly_smiling_face: