AlbertoPdRF / root-file-viewer

View ROOT files directly in VS Code!
https://marketplace.visualstudio.com/items?itemName=albertopdrf.root-file-viewer
MIT License
47 stars 5 forks source link

Lack of draw same option #24

Closed PuttyDeVil closed 1 year ago

PuttyDeVil commented 1 year ago

How to draw two histogram in the same canvas? In the latest web version of JSROOT 7.4, I can drag another histogram into an existing canvas, but this function doesn't work in the vscode extension. I find this extension is using the JSROOT 7.2.0 now. Is this problem from the difference of versions?

AlbertoPdRF commented 1 year ago

Hi! I didn't know this feature existed. I just tried in my local machine after upgrading JSROOT to v7.4.0 and it still doesn't work. This is the error I see in the developer console:

Error

Maybe @linev knows what the error is about?

linev commented 1 year ago

I cannot reproduce problem with plain JSROOT in web browser. Probably something differs in VS code.

PuttyDeVil commented 1 year ago

Thank you very much! Hope more convenient functions can be used in VS code in the future.

Hi! I didn't know this feature existed. I just tried in my local machine after upgrading JSROOT to v7.4.0 and it still doesn't work. This is the error I see in the developer console:

Error

Maybe @linev knows what the error is about?

linev commented 1 year ago

Hi! I didn't know this feature existed. I just tried in my local machine after upgrading JSROOT to v7.4.0 and it still doesn't work. This is the error I see in the developer console:

Error

Maybe @linev knows what the error is about?

I found a reason for the bug. Fix is very simple. I can publish it in 7.4.1 release.

AlbertoPdRF commented 1 year ago

That would be awesome! Thanks @linev 🚀

linev commented 1 year ago

Draw same will be available in next jsroot release. It is in the current master already, but release is far away.

AlbertoPdRF commented 1 year ago

Thank you for the info! I will make sure to upgrade JSROOT's version as soon as it comes out :slightly_smiling_face: