search

AlbertoPdRF / root-file-viewer

View ROOT files directly in VS Code!
https://marketplace.visualstudio.com/items?itemName=albertopdrf.root-file-viewer
MIT License
47 stars 5 forks source link

Improve visual integration / use VSCode color palette #3

Open dnwerner opened 3 years ago

dnwerner commented 3 years ago

Visual Studio Code uses a wide range of different visual styles. It would be a great visual improvement if the extension could reflect the default editor background color, or try to match the editor's color palette in its header bar.

AlbertoPdRF commented 3 years ago

Thanks for openning this issue @dnwerner!

I agree that this would improve the experience of using the extension, and I see a couple of routes that we could take in order to accomplish that. However, it would also require quite a bit of work to get everything looking good, so I'm not sure if/when I will be able to work on this

AlbertoPdRF commented 3 years ago

:information_source: In 3cde4eb376f561ce81e4c76c92d5ff40f3711134 it can be seen how to override JSROOT's default styles

dnwerner commented 2 years ago

The issue became a bit more important recently: The new tab bar, although a welcome re-addition, suffers from poor contrast in a few of the default color dark schemes when using the extension in "light mode" - it seems like the background of the tabs either uses an incorrect palette-color or the font color is chosen incorrectly.

image

Contrast is much better in the extension's dark mode and seems to work as intended there - but the dark mode makes the content very dark, which might not always be preferable. It might be helpful to have separate dark-modes for content and UI?

dnwerner commented 2 years ago

There seem to be a few additional issues:

  1. There seems to be no highlight color for the currently selected tab
  2. (minor) there probably shouldn't be a black bar at the bottom of the currently active tab, since in "tab-layout-logic" it's part of the same content
  3. The old tab bar's high-capacity/overflow behavior drew the tab titles in multiple lines - could this be re-introduced as optional behavior in the future?
AlbertoPdRF commented 1 year ago

Thanks for all the comments @dnwerner! I've addressed some of the issues you mentioned in 0a7dc414441561d92fb3da3160d7246e173c4dbb, which will be included in a release soon. For the overflow behaviour (point 3 in comment) I'm CC'ing @linev, as maybe this should be handled in JSROOT's side.

On a related note: the extension would definitely benefit of a full revamp of the UI to match more closely the editor's styles, but I don't think I have the capacity to work on that. If someone is interested in the project, any help is welcome! :slightly_smiling_face:

linev commented 1 year ago

The old tab bar's high-capacity/overflow behavior drew the tab titles in multiple lines - could this be re-introduced as optional behavior in the future?

This is need some work - now JSROOT do not uses jquery-ui and needs to implement such features itself. I cannot promise to implement it soon