AlbertoPdRF / root-file-viewer

View ROOT files directly in VS Code!
https://marketplace.visualstudio.com/items?itemName=albertopdrf.root-file-viewer
MIT License
49 stars 5 forks source link

Add fit-tool integration #4

Closed dnwerner closed 3 years ago

dnwerner commented 3 years ago

Thanks for the great project! If possible could you add a rudimentary fit tool akin to the TBrowser-included tool (might be out of scope / technically impossible)?

AlbertoPdRF commented 3 years ago

And thanks for this issue too, @dnwerner!

I originally thought about adding a command to the extension that opens an integrated TBrowser and let's you do everything that you would expect, but I don't think this is possible with JavaScript ROOT -- maybe @linev can let us know if there are any plans to support the TBrowser class within JSROOT?

linev commented 3 years ago

No - fitting will require rewriting a lot of code, which is implemented in ROOT. Therefore in such case one have to install and use ROOT directly

AlbertoPdRF commented 3 years ago

Thanks for another very quick reply and for the info @linev!

@dnwerner I'm going to close this issue as it indeed seems to be out of scope