search

AlbertoPdRF / root-file-viewer

View ROOT files directly in VS Code!
https://marketplace.visualstudio.com/items?itemName=albertopdrf.root-file-viewer
MIT License
47 stars 5 forks source link

Modals from JS ROOT aren't being displayed #6

Closed AlbertoPdRF closed 3 years ago

AlbertoPdRF commented 3 years ago

I just noticed that modals (e.g. prompt) aren't working, so all JavaScript ROOT functionality that uses them (e.g. setting an axis range) isn't working either.

Related: https://github.com/Microsoft/vscode/issues/67109

linev commented 3 years ago

For rebinning there are several values in sub-menu which can be selected without input prompt. But one could think of some other alternative - I create issue https://github.com/root-project/jsroot/issues/216 as reminder.

AlbertoPdRF commented 3 years ago

That would be awesome @linev, let me know if I can help in any way!