search

AlbinoDrought / cachios

Simple axios cache wrapper using node-cache
MIT License
88 stars 10 forks source link

Patch 9/10 introduces a breaking change. #29

Closed erikkrieg closed 6 years ago

erikkrieg commented 6 years ago

We noticed tests for one of our services started failing recently after updating our dependencies. We identified cachios as a common lib across failing tests and locked ourselves into a previous version which fixed our failing tests.

I took a look at https://github.com/AlbinoDrought/cachios/pull/28 and noticed the package-lock has changed for several dependencies, so we think one of those changes is the culprit.

erikkrieg commented 6 years ago

For additional info, the failing tests were throwing Error: connect ECONNREFUSED 127.0.0.1:443, but we did not dig deeper after locking the patch version of cachios.

AlbinoDrought commented 6 years ago

I'm thinking this was due to an axios package upgrade (0.17.1 -> 0.18.0). Probably should have bumped minor version.

1.0.8, the working package, has been republished as 1.0.11.

1.0.10, the previously-breaking package, has been republished as 1.1.0.

Let me know how it goes!

erikkrieg commented 6 years ago

Our tests are working with 1.0.11 :)

AlbinoDrought commented 6 years ago

Ok, cool! I'll try to not break stuff next time :)