AlbrechtL / welle.io

A DAB/DAB+ Software Defined Radio (SDR)
https://www.welle.io
Other
612 stars 115 forks source link

[next] Mono stations are shown as stereo #277

Closed andimik closed 6 years ago

andimik commented 6 years ago

In Slovenija, some stations use 32 kHz 24 kBit mono, but it is shown as stereo.

grafik

Tested with b68d488 .

slo_10d_2018-07-08_1146.eti.zip

cat slo_10d_2018-07-08_1146.eti | odr-dabmod eti2raw.ini | ./20180717_b68d488_Linux_welle-io-x86_64.AppImage --raw-file /dev/stdin -d rawfile

and eti2raw.ini is

[input]
transport=file
source=/dev/stdin

[modulator]
gainmode =1
rate=2048000

[output]
output=file

[fileoutput]
format=u8
filename=/dev/stdout

Dablin shows mono (and I know it as well)

grafik

AlbrechtL commented 6 years ago

Can it be that this station uses parametric stereo?

basicmaster commented 6 years ago

No, as in such a case DABlin indicates "HE-AAC v2" and "Stereo".

andimik commented 6 years ago

No, this is mono.

AlbrechtL commented 6 years ago

OK then, it seems to be a bug.

mpbraendli commented 6 years ago

Wow, your ETI file has a lot of frame count discontinuities! I think I'll generate an ETI with all combinations to test.

andimik commented 6 years ago

I see, I will check with another one

mpbraendli commented 6 years ago

I've generated a mux with a few programmes: MP2 mono, MP2 stereo, AAC-LC mono, AAC with SBR mono, AAC-LC stereo, AAC with SBR stereo and AAC with PS.

dablin indication is correct.

welle-cli with -Dw 7979 shows this:

screenshot_20180723_111905

The entry for AAC-LC stereo is wrong, it shows one channel. I'll see now what welle-io prints.

mpbraendli commented 6 years ago

welle-io does the same error, except it doesn't show the AAC mode (LC, SBR or PS). I'll fix the AAC stereo LC case.

mpbraendli commented 6 years ago

Fixed in 0cac18f

And I discovered that welle-cli cannot handle mono streams at all :-/ Another thing to debug...

@andimik please open the issue again if you still have a problem with the signalling of mono/stereo with your programme!

andimik commented 6 years ago

Merci :-)

mpbraendli commented 6 years ago

welle-cli mono decoding is now also fixed.

AlbrechtL commented 6 years ago

Makes it sense to print the AAC mode in welle-io in expert mode as well?

mpbraendli commented 6 years ago

I believe it makes sense. This idea is tracked in https://github.com/AlbrechtL/welle.io/projects/1#card-9663493 already.

AlbrechtL commented 6 years ago

You are right. I added this issue to the card.