Makefile: Respect the CXX environment variable.

Alcaro / Flips

Floating IPS is a patcher for IPS and BPS files.

Other

334 stars 46 forks source link

Makefile: Respect the CXX environment variable. #22

Closed orbea closed 5 years ago

orbea commented 5 years ago

This allows overriding CXX with an environment variable so that I can build flips with clang++ instead of g++.

Warning this exposes a new issue when build with clang-8.0.0.

clang-8: warning: treating 'c' input as 'c++' when in C++ mode, this behavior is deprecated [-Wdeprecated]

I tested this with one sfc patch and found it created identical files when built with g++ and clang++.

Alcaro commented 5 years ago

I always use make CXX=clang++, so Make ignores that assignment. But allowing env to win does indeed make sense.

That C/C++ mismatch would be annoying to fix with the current makefile scheme, and I doubt it's worthwhile. And it'd show up if you do make CXX=clang++ on current head, anyways; you're not adding any new bugs.