Alcaro / Flips

Floating IPS is a patcher for IPS and BPS files.
Other
309 stars 45 forks source link

Compilation fails due to integer comparison #4

Closed superjamie closed 6 years ago

superjamie commented 6 years ago

Ubuntu 16.04, dependencies seem to be met fine.

$ ./make.sh                                                                                                                                                                                                            
rm: cannot remove 'flips.exe': No such file or directory
rm: cannot remove 'floating.zip': No such file or directory
rm: cannot remove 'flips': No such file or directory
rm: cannot remove 'rc.o': No such file or directory
rm: cannot remove '*.gcda': No such file or directory
GTK+ (1/3)
rm: cannot remove 'flips': No such file or directory
g++ flips-cli.cpp libbps-suf.cpp libbps.cpp libips.cpp crc32.cpp libups.cpp flips-w32.cpp flips.cpp flips-gtk.cpp -std=c++98 -Wall -Werror -O3 -fomit-frame-pointer -fmerge-all-constants -fvisibility=hidden -fno-exceptions -fno-unwind-table
s -fno-asynchronous-unwind-tables -ffunction-sections -fdata-sections -Wl,--gc-sections -fprofile-generate -lgcov -fno-rtti -fno-exceptions -DNDEBUG -fopenmp -DFLIPS_GTK -pthread -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr
/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/mirclient -I/usr/include/mircore -I/usr/include/mircookie -I/usr/include/cairo -I/u
sr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng1
2 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0  -Ilibdivsufsort-2.0.1/include -DHAVE
_CONFIG_H -D__STDC_FORMAT_MACROS libdivsufsort-2.0.1/lib/divsufsort.c libdivsufsort-2.0.1/lib/sssort.c libdivsufsort-2.0.1/lib/trsort.c   -oflips
libbps.cpp: In function ‘bpserror bps_create_linear(mem, mem, mem, mem*)’:
libbps.cpp:287:38: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
   if (numunchanged>1 || numunchanged == targetend-target)
                                      ^
cc1plus: all warnings being treated as errors
Makefile:91: recipe for target 'flips' failed
make: *** [flips] Error 1

Both make TARGET=cli DIVSUF=no and make TARGET=gtk LFLAGS='-lgcov' result in a binary and no warning, so I guess it's one of the FLAGS set in your script picking this up.