search

Alcaro / Flips

Floating IPS is a patcher for IPS and BPS files.
Other
334 stars 46 forks source link

Use GTKFileChooserNative instead of GTKFileChooser #70

Closed Miepee closed 6 months ago

Miepee commented 6 months ago

Fixes #69

I have tested this by using the Apply Patch and Create Patch functions. They didn't have any regressions. Apply and Run also didn't have any functional regressions. But the custom executable filter was removed due to it not being supported on native file pickers (see comment).

Miepee commented 6 months ago

is CI just broken? Its error message doesnt seem to line up with my diff.

Alcaro commented 6 months ago

Looks like the CI was trying to use Ubuntu 18.04, which is no longer supported and apparently no longer functional.

I switched it to 22.04. Rebase your pull, and it should work better.

(The Windows CI has a pretty old mingw, too... but Flips doesn't use any advanced features, so it's fine. For now.)

Miepee commented 6 months ago

ty, seems to have worked!

Alcaro commented 6 months ago

Looks good to me, and if it also looks good to you and the CI, let's just trust it is good.