search

Alcaro / Flips

Floating IPS is a patcher for IPS and BPS files.
Other
309 stars 45 forks source link

Clang warns about deprecated sprintf #74

Closed Miepee closed 1 month ago

Miepee commented 1 month ago

It suggests to use snprintf over sprintf due to security reasons. I'm not a cpp guy, so just opening this issue for completeness sake. Feel free to close this as invalid if you think its a non-issue. https://github.com/Alcaro/Flips/actions/runs/9197615734/job/25298479967

Alcaro commented 1 month ago

let's see if I missed anything. I probably did. https://github.com/Alcaro/Flips/actions/runs/9197842175

Miepee commented 1 month ago

Nope, those warnings are all gone now.

Alcaro commented 1 month ago

I thought there'd be a sprintf or two on the Windows side that I forgot fixing. Apparently not.

(Well, there's a 'wsprintf redefined' warning, but that's easy to fix.)

Miepee commented 1 month ago

OH actually, not sure if its the same issue, but windows is complaining about redefinition for wsprintf: https://github.com/Alcaro/Flips/actions/runs/9197842175/job/25299205951

EDIT: just saw your message, whoops