search

Alchemist0823 / three.quarks

Three.quarks is a general purpose particle system / VFX engine for three.js
https://quarks.art
480 stars 22 forks source link

Trails not working in r152 #56

Closed theripper93 closed 1 year ago

theripper93 commented 1 year ago

Trails are not working in the latest threejs release

hybridherbst commented 1 year ago

Looks like the UV change in three (allowing multiple UV channels) affects the shaders here. image

E.g. these need to be probably changed: https://github.com/Alchemist0823/three.quarks/blob/654972c7b83740b4add9f1b1a7c504658bd98ddb/src/shaders/particle_frag.glsl.ts#LL20C44-L20C44

hybridherbst commented 1 year ago

@Alchemist0823 are you interested in a PR?

Alchemist0823 commented 1 year ago

Thanks for pointing out. Yeah, I am open for RP.

Alchemist0823 commented 1 year ago

Fix in 0a4c2ef16c18db7f337e471c5c339b047577b764