Alchemist0823 / three.quarks

Three.quarks is a general purpose particle system / VFX engine for three.js
https://quarks.art
480 stars 22 forks source link

Three.js is used as dependency, not peer dependency #58

Closed hybridherbst closed 1 year ago

hybridherbst commented 1 year ago

I was investigating why we always get double versions of three in some applications. Turns out that three.quarks is the only package in the chain that is pulling in an actual version of three and not a peerDependency, which would correctly resolve to the actual intended three version.

Are you open to changing this? Should just be moving three from "dependency" to "peerDependency". Thanks!

image