AlchemistSimulator / Alchemist

Alchemist: an extensible simulator for pervasive computing
Other
40 stars 46 forks source link

build(web-renderer): remove useless spotbugs lib in kotlin/js project #3739

Closed AngeloFilaseta closed 2 months ago

AngeloFilaseta commented 2 months ago

This PR will solve the following problem. It was caused by the spotbugs lib, which was incorrectly imported in a Kotlin/JS project using compileOnly. Spotbugs is already correctly configured in the root build.gradle.kts so I simply removed it in the specific project.

2024-09-02T15:14:29.9352380Z w: A compileOnly dependency is used in targets: Kotlin/JS.
2024-09-02T15:14:29.9353297Z Dependencies:
2024-09-02T15:14:29.9354327Z     - com.github.spotbugs:spotbugs-annotations:4.8.6 (source sets: jsMain)
2024-09-02T15:14:29.9355207Z 
2024-09-02T15:14:29.9356738Z Using compileOnly dependencies in these targets is not currently supported, because compileOnly dependencies must be present during the compilation of projects that depend on this project.
2024-09-02T15:14:29.9358471Z 
2024-09-02T15:14:29.9359381Z To ensure consistent compilation behaviour, compileOnly dependencies should be exposed as api dependencies.
2024-09-02T15:14:29.9360526Z 
2024-09-02T15:14:29.9360832Z Example:
2024-09-02T15:14:29.9361217Z 
2024-09-02T15:14:29.9361518Z     kotlin {
2024-09-02T15:14:29.9362123Z         sourceSets {
2024-09-02T15:14:29.9362778Z             nativeMain {
2024-09-02T15:14:29.9363468Z                 dependencies {
2024-09-02T15:14:29.9364758Z                     compileOnly("org.example:lib:1.2.3")
2024-09-02T15:14:29.9365887Z                     // additionally add the compileOnly dependency as an api dependency:
2024-09-02T15:14:29.9367254Z                     api("org.example:lib:1.2.3")
2024-09-02T15:14:29.9368099Z                 }
2024-09-02T15:14:29.9368697Z             }
2024-09-02T15:14:29.9369281Z         }
2024-09-02T15:14:29.9369821Z     }
2024-09-02T15:14:29.9370184Z 
2024-09-02T15:14:29.9370648Z This warning can be suppressed in gradle.properties:
2024-09-02T15:14:29.9371337Z 
2024-09-02T15:14:29.9372029Z     kotlin.suppressGradlePluginWarnings=IncorrectCompileOnlyDependencyWarning
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (6ee3007) to head (96ab20b). Report is 984 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3739 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 3 2 -1 Lines 115 67 -48 Branches 5 2 -3 ====================================== + Misses 115 67 -48 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

DanySK commented 1 month ago

:tada: This PR is included in version 34.1.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: