search

Alchemy-se / Vattenfall-One-Brand-Design-System

DDS
3 stars 4 forks source link

Image Block component - different layout when reversed #100

Closed wwitekk closed 5 years ago

wwitekk commented 5 years ago

Hi

Image Block component when reversed displays text differently (2 lines instead of 1 in header). Please find image below.

image

Another issue is that in the example (https://digitaldesign.vattenfall.com/css/image-block) you are using rounded png image. Do you really want us to use rounded png image in here?

Regards

Witold

alchemychrishall commented 5 years ago

Hi Witold!

Thanks for letting us know. The padding has been standardised, and so the text will now be displayed in the same way.

Yes, the rounded image is correct there.

Regards,

Chris

wwitekk commented 5 years ago

Hi Chris,

Thank you very much for your feedback and quick bug fix.

Just one more regarding rounded images. Still not understand why you do not want to add little bit of css like:

.vf-image-block { &__media { img { height: 250px; width: 250px; border-radius: 50%; object-fit: cover; } }

I am using the component inside cms - that will be impossible to explain to editors why and how to prepare rounded png. They want to download an image from Frontify media library and upload it into cms with no additional edition.

Witold