App doesn't work if favicon isn't present

[puckettgw]

Steps to reproduce

Build a site without a favicon

Expected behavior

Should just 404 for the favicon

Actual behavior

Fails to render page, poops out stack trace:

Sprockets::Rails::Helper::AssetNotFound in Alchemy::Admin::Dashboard#index
Showing /usr/local/rvm/gems/ruby-2.7.5/gems/alchemy_cms-5.3.3/app/views/layouts/alchemy/admin.html.erb where line #7 raised:

The asset "alchemy/favicon.ico" is not present in the asset pipeline.

System configuration

• Alchemy Version: 5.3-stable
• Rails Version: 6.0.4.7

[puckettgw]

Also happens on 5.0.10.

I also get another error, possibly related:

undefined method `locale' for #<Alchemy::Language:0x0000563900ce1168>
activemodel (6.0.4.7) lib/active_model/attribute_methods.rb:432:in `method_missing'
alchemy_cms (5.0.10) app/controllers/alchemy/base_controller.rb:30:in `set_locale'

Maybe an install step didn't work? The odd thing is I used the quickstart instructions.

[tvdeyen]

The favicon in question here is the admin favicon from Alchemy, not the favicon of the site. Honestly I don't know why this error is happening.

The second error is not related at all. This seems like a missing migration. From the stack trace I see that you are using 5.0.10 here, while you are using 5.3.3 in the upper error.

Make sure that you have installed Alchemy properly and run

bin/rake alchemy:upgrade

for every update you do.

[github-actions[bot]]

This issue has not seen any activity in a long time. Please create a pull request with a fix or ask someone of the community if they can help. This issue will be closed in 7 days if no further activity happens.

[github-actions[bot]]

This issue has not seen any activity in a long time. If the issue described still exists in recent versions of Alchemy, please open a new issue with. Thanks for reporting.