dssjoblom
commented
1 year ago So I did some digging into this. It looks like a classic race-condition. In alchemy-dragonfly-s3:
module Alchemy
module Dragonfly
module S3
class CreatePictureThumb
def self.call(variant, signature, uid)
# create the thumb before uploading
# to prevent db race conditions
thumb = nil
if variant.picture.valid?
thumb = Alchemy::PictureThumb.create!(
picture: variant.picture,
signature: signature,
uid: uid,
)
end
begin
# fetch and process the image
image = variant.image
# upload the processed image
image.store(path: uid)
rescue RuntimeError, Excon::Error => e
ErrorTracking.notification_handler.call(e)
# destroy the thumb if processing or upload fails
thumb&.destroy
end
end
end
end
end
endShouldn't this use something like https://apidock.com/rails/ActiveRecord/Relation/create_or_find_by ?
tvdeyen
Steps to reproduce
When upgrading from an older 6.0.0-pre version to 6.1.1, it seems that there are duplicate key violations while rendering the templates. Strangely enough, reloading the page makes the error go away.
Update: I get this also in the admin portion. If I upload an image and use it in an element, the preview always generates the same error. When I reload the preview, the image is there and everything works normally.
Stacktrace:
Expected behavior
There should be no duplicate key violations. I'd also not expect a GET request to cause database writes (like thumbnail creation), see #2428
Actual behavior
I get a duplicate key violation. It's also mysterious that once the same page is loaded again the error disappears.
System configuration