AlchemyCMS / alchemy_cms

Alchemy is the Open Source Rails CMS framework for the component based web that can be used as classic server side rendered or headless CMS.
https://www.alchemy-cms.com
BSD 3-Clause "New" or "Revised" License
829 stars 313 forks source link

Use svg remixicons #2749

Closed tvdeyen closed 6 months ago

tvdeyen commented 6 months ago

What is this pull request for?

Instead of a iconfont we use the svg icon sprite to render icons. This includes a new component <alchemy-icon> with name, size and icon-style props.

With https://github.com/rails/rails/pull/50359 being merged svgs will be precompressed during asset compilation, which makes a huge difference on transferred file size.

Notable changes

Removes the icon fonts and ri- classes for <i> elements.

Checklist

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.81%. Comparing base (63d5474) to head (7fb12a0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2749 +/- ## ======================================= Coverage 95.80% 95.81% ======================================= Files 221 222 +1 Lines 6078 6087 +9 ======================================= + Hits 5823 5832 +9 Misses 255 255 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.