Fix SVG Preview size - Githubissues

AlchemyCMS / alchemy_cms

Alchemy is the Open Source Rails CMS framework for the component based web that can be used as classic server side rendered or headless CMS.

https://www.alchemy-cms.com

BSD 3-Clause "New" or "Revised" License

823 stars 311 forks source link

Fix SVG Preview size #2786

Closed sascha-karnatz closed 5 months ago

sascha-karnatz commented 5 months ago

What is this pull request for?

The URL of the SVG preview normally don't have an SVG extension, but it contains svg in the given asset URL. There is a (rare) possibility, that the asset hash of a non-SVG image will also contain that three characters, but it does not seem like a big deal, because it would only increase the height of outer container.

Screenshots

Aufnahme 2024-03-12 at 08 33 18@2x

Checklist

[x] I have followed Pull Request guidelines
[x] I have added a detailed description into each commit message
[ ] I have added tests to cover this change

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.80%. Comparing base (63d5474) to head (d7b880d).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2786 +/- ## ======================================= Coverage 95.80% 95.80% ======================================= Files 221 221 Lines 6078 6078 ======================================= Hits 5823 5823 Misses 255 255 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tvdeyen commented 5 months ago

Closing until we come up with a better solution (ie. an alchemy-picture-thumbnail component)