Refactor link dialog into ES module

sascha-karnatz commented 5 months ago

What is this pull request for?

Use our default page select web component also in the link dialog. This simplifies the link dialog (a bit) and removes an Handlebar template, which isn't necessary anymore.
move the anchor select into an own web component
move the logic which is generating the link outside of the link dialog
migrate the LinkDialog CoffeeScript file into a Javascript file
replace jQuery with vanilla Javascript

Checklist

[x] I have followed Pull Request guidelines
[x] I have added a detailed description into each commit message
[x] I have added tests to cover this change

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 98.11321% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.92%. Comparing base (8175627) to head (4dc39a2).

Files	Patch %	Lines
...p/components/alchemy/admin/link_dialog/base_tab.rb	93.33%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2796 +/- ## ========================================== + Coverage 95.90% 95.92% +0.01% ========================================== Files 225 225 Lines 6103 6129 +26 ========================================== + Hits 5853 5879 +26 Misses 250 250 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sascha-karnatz commented 5 months ago

Linking an anchor does not work unfortunately

Should work now

AlchemyCMS / alchemy_cms