AlchemyCMS / alchemy_cms

Alchemy is the Open Source Rails CMS framework for the component based web that can be used as classic server side rendered or headless CMS.
https://www.alchemy-cms.com
BSD 3-Clause "New" or "Revised" License
823 stars 311 forks source link

Use Turbo Frame for Elements Window #2801

Closed tvdeyen closed 5 months ago

tvdeyen commented 5 months ago

What is this pull request for?

Instead of using our own fetch logic on a DIV container we make use of a Turbo Frame.

For now we need to disable the submit buttons inside, because we still use Rails UJS and the remote forms feature that uses js.erb responses from the controller.

Those need to be refactored into Turbo Streams eventually, but this is too much for now.

Checklist

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.89%. Comparing base (fb34795) to head (857c2b3).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2801 +/- ## ======================================= Coverage 95.89% 95.89% ======================================= Files 224 224 Lines 6097 6097 ======================================= Hits 5847 5847 Misses 250 250 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.