AlchemyCMS / alchemy_cms

Alchemy is the Open Source Rails CMS framework for the component based web that can be used as classic server side rendered or headless CMS.
https://www.alchemy-cms.com
BSD 3-Clause "New" or "Revised" License
818 stars 312 forks source link

Add delete-element-button #2818

Closed tvdeyen closed 3 months ago

tvdeyen commented 3 months ago

What is this pull request for?

Instead returning imperative JS from a js.erb server response (that only works with the deprecated rails-ujs library) we introduce another web component that uses the also introduced ConfirmDialog ES class and a promised based approach to do the things we do after we removed an element.

Checklist

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.92%. Comparing base (fc97f93) to head (5e789e0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2818 +/- ## ========================================== - Coverage 95.92% 95.92% -0.01% ========================================== Files 225 225 Lines 6129 6128 -1 ========================================== - Hits 5879 5878 -1 Misses 250 250 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.