search

AlchemyCMS / alchemy_cms

Alchemy is the Open Source Rails CMS framework for the component based web that can be used as classic server side rendered or headless CMS.
https://www.alchemy-cms.com
BSD 3-Clause "New" or "Revised" License
818 stars 312 forks source link

Fix module error #2820

Closed mamhoff closed 3 months ago

mamhoff commented 3 months ago

What is this pull request for?

The error message in Alchemy::Modules.validate_controllers_existence relies on the definition_hash variable to be present. Because it isn't, we get a NameError rather than the expected RuntimeError.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.92%. Comparing base (fc97f93) to head (d38d50c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2820 +/- ## ======================================= Coverage 95.92% 95.92% ======================================= Files 225 225 Lines 6129 6129 ======================================= Hits 5879 5879 Misses 250 250 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alchemycms-bot commented 3 months ago

💚 All backports created successfully

Status Branch Result
✅ 7.0-stable
✅ 7.1-stable

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details