AlchemyCMS / alchemy_cms

Alchemy is the Open Source Rails CMS framework for the component based web that can be used as classic server side rendered or headless CMS.
https://www.alchemy-cms.com
BSD 3-Clause "New" or "Revised" License
818 stars 312 forks source link

Use Shoelace Dialog for ConfirmDialog #2823

Closed tvdeyen closed 3 months ago

tvdeyen commented 3 months ago

What is this pull request for?

We have our own Dialog JS class. We should not have a complicated component like this in our code base. Instead we should use the Shoelace Dialog that has better accessibility and UX.

Since our dialog is meant to load remote content we first migrate its little sister ConfirmDialog, which just displays text.

This also adds a remixicon theme to shoelace (based on the SVG sprite sheet) and updates Shoelace to 2.15.0 because of a bug in icon set registration.

Checklist

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.92%. Comparing base (f0b0403) to head (88454b5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2823 +/- ## ======================================= Coverage 95.92% 95.92% ======================================= Files 225 225 Lines 6128 6128 ======================================= Hits 5878 5878 Misses 250 250 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.