search

AlchemyCMS / alchemy_cms

Alchemy is the Open Source Rails CMS framework for the component based web that can be used as classic server side rendered or headless CMS.
https://www.alchemy-cms.com
BSD 3-Clause "New" or "Revised" License
818 stars 312 forks source link

Nullify Ingredients::Page on Page destroy #2829

Closed mamhoff closed 3 months ago

mamhoff commented 3 months ago

When we delete a page, page ingredients that point to that page should be nullified.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.86%. Comparing base (8fb247c) to head (d183256).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2829 +/- ## ========================================== + Coverage 95.84% 95.86% +0.01% ========================================== Files 227 227 Lines 6185 6186 +1 ========================================== + Hits 5928 5930 +2 + Misses 257 256 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mamhoff commented 3 months ago

There is a commit in 6.1-stable that does the same for EssencePages: https://github.com/AlchemyCMS/alchemy_cms/commit/35e0a3c3c2749435cf7001d7f3451a43ec650d9c

alchemycms-bot commented 3 months ago

💚 All backports created successfully

Status Branch Result
✅ 7.0-stable
✅ 7.1-stable

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details