Closed Olli closed 3 months ago
Can you try replacing the dependency with something more modern, and make sure the css still compiles and works?
I would love to be able to remove the dependency from this Gem. But: As Martin mentioned, we still have Sass code that compiles with the app assets. Unless JS where we now use importmaps I don't see anything comparable for Sass.
We could compile our own Sass into a bundle, but then we lose the ability to bundle into the Admin CSS. But maybe this is fine, as this is rarely done.
Long story short. It is too early to remove the dependency for now.
Unfortunately, because I want to see it gone as well.
I'm not against scss ... I still use it but with dartsass-sprockets (which is a drop-in replacement) or dartsass-rails. But I see the problem - not everyone has changed to or is using dartsass yet. The other solution is to fully switch to pure css.
Never heard of dartsass-sprockets
before. It's even an official Rails gem. Nice! Mind to give it a try in another PR?
Ah, there is https://github.com/rails/dartsass-rails and https://github.com/tablecheck/dartsass-sprockets
Would like to use the official Rails gem.
What is this pull request for?
I want to remove the rails-sassc dependency because it's outdated. There are alternatives and sassc doesn't compile "modern" scss code anymore. The dependency to this old lib does create problems with more modern approaches to compile scss like the dartsass-sprockets.
Checklist