Add a new dialog class to replace the old one

AlchemyCMS / alchemy_cms

Alchemy is the Open Source Rails CMS framework for the component based web that can be used as classic server side rendered or headless CMS.

https://www.alchemy-cms.com

BSD 3-Clause "New" or "Revised" License

818 stars 312 forks source link

Add a new dialog class to replace the old one #2858

Open sascha-karnatz opened 2 months ago

sascha-karnatz commented 2 months ago

Add a new dialog class with the same signature and the same properties as the old Dialog implementation. The new one is using the shoelace web components and is working with promises to allow the calling method to react to the user input in the dialog.

Checklist

[x] I have followed Pull Request guidelines
[x] I have added a detailed description into each commit message
[x] I have added tests to cover this change

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.96%. Comparing base (0133ea7) to head (6e218f2). Report is 3 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2858 +/- ## ======================================= Coverage 95.96% 95.96% ======================================= Files 232 232 Lines 6271 6271 ======================================= Hits 6018 6018 Misses 253 253 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tvdeyen commented 2 months ago

We need a remote form watcher that handles re-rendering of forms with validation errors

See https://github.com/AlchemyCMS/alchemy_cms/blob/cbef269040d7c43c1d6d8cc54d8433450c698d3d/app/assets/javascripts/alchemy/alchemy.dialog.js.coffee#L104-L119

https://github.com/AlchemyCMS/alchemy_cms/assets/42868/6aa07cff-ac71-44ac-b7f9-51287ed966c3