search

AlchemyCMS / alchemy_cms

Alchemy is the Open Source Rails CMS framework for the component based web that can be used as classic server side rendered or headless CMS.
https://www.alchemy-cms.com
BSD 3-Clause "New" or "Revised" License
817 stars 312 forks source link

Use inline styles for menubar component #2893

Closed tvdeyen closed 1 month ago

tvdeyen commented 1 month ago

What is this pull request for?

Since we use shadow dom anyway we can just inline the styles and remove the necessity to precompile it.

Screenshots

closed

menubar-closed

open

menubar-open

localized

menubar-de

open focus

menubar-focus

Checklist

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.95%. Comparing base (70b0d49) to head (98ca8f8). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2893 +/- ## ======================================= Coverage 95.95% 95.95% ======================================= Files 230 230 Lines 6258 6258 ======================================= Hits 6005 6005 Misses 253 253 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.