AlchemyCMS / alchemy_cms

Alchemy is the Open Source Rails CMS framework for the component based web that can be used as classic server side rendered or headless CMS.
https://www.alchemy-cms.com
BSD 3-Clause "New" or "Revised" License
817 stars 312 forks source link

fix(InternalTab): Fix for urls with trailing slash and no locale #2897

Closed tvdeyen closed 1 month ago

tvdeyen commented 1 month ago

What is this pull request for?

The former regexp was ignoring the second slash in urls without locale but with trailing slash, since it was not part of the locale group and optional. Using a non match group for the optional locale and it's optional slash.

Checklist

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.96%. Comparing base (7fec21c) to head (8ce686e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2897 +/- ## ======================================= Coverage 95.96% 95.96% ======================================= Files 230 230 Lines 6269 6269 ======================================= Hits 6016 6016 Misses 253 253 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.