search

AlchemyCMS / alchemy_cms

Alchemy is the Open Source Rails CMS framework for the component based web that can be used as classic server side rendered or headless CMS.
https://www.alchemy-cms.com
BSD 3-Clause "New" or "Revised" License
817 stars 312 forks source link

Add name attribute to Preview IFrame #2908

Closed mamhoff closed 1 month ago

mamhoff commented 1 month ago

What is this pull request for?

In Alchemy 7.1, the preview Iframe had a name attribute that could be reference from inside the iframe by using window.name. With 7.2, this isn't the case anymore, and our (admittedly a bit special implementation) of previews have stopped working because of this missing attribute.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.96%. Comparing base (e5f8d3c) to head (caab029).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2908 +/- ## ======================================= Coverage 95.96% 95.96% ======================================= Files 232 232 Lines 6273 6273 ======================================= Hits 6020 6020 Misses 253 253 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.