Closed tvdeyen closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.97%. Comparing base (
87205af
) to head (0ec35d5
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What about the getters? Should those be overwritten, too, to make sure existing values in the database aren't strings/numbers?
Thought about it, but current users will have their solution if they encounter the bug, and I didn't want to serialize twice for every website.
so, now people can pro actively change the values in the database by saving it once and we do not do more than necessary
Status | Branch | Result |
---|---|---|
✅ | 7.0-stable | |
✅ | 7.1-stable | |
✅ | 7.2-stable |
Please refer to the Backport tool documentation and see the Github Action logs for details
What is this pull request for?
Currently boolean values of ingredient video and audio are stored as strings ("0"/"1") in the data column JSON.
Cast to Boolean before we save to make this booleans.
Checklist