Split dashboard into partials

AlchemyCMS / alchemy_cms

Alchemy is the Open Source Rails CMS framework for the component based web that can be used as classic server side rendered or headless CMS.

https://www.alchemy-cms.com

BSD 3-Clause "New" or "Revised" License

817 stars 313 forks source link

Split dashboard into partials #2948

Closed tvdeyen closed 1 week ago

tvdeyen commented 1 week ago

What is this pull request for?

The dashboard has now partials for each part (top, left_column, right_column) and widgets for the content placed into them. It looks the same as before, but can now be changed in the host app or extensions by overwriting on of the partials.

Checklist

[x] I have followed Pull Request guidelines
[x] I have added a detailed description into each commit message

sascha-karnatz commented 1 week ago

Looks good! In the long run we can consider ViewComponents for the Widgets.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.96%. Comparing base (ce2fc9d) to head (e1ee2e9).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2948 +/- ## ======================================= Coverage 95.96% 95.96% ======================================= Files 232 232 Lines 6271 6271 ======================================= Hits 6018 6018 Misses 253 253 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tvdeyen commented 1 week ago

Looks good! In the long run we can consider ViewComponents for the Widgets.

Yes, in the partials we could use ViewComponents, but partials are way easier to overwrite than ViewComponents