AlchemyCMS / alchemy_cms

Alchemy is the Open Source Rails CMS framework for the component based web that can be used as classic server side rendered or headless CMS.
https://www.alchemy-cms.com
BSD 3-Clause "New" or "Revised" License
817 stars 313 forks source link

Wrap error responses in turbo-frame tags #2949

Closed tvdeyen closed 3 days ago

tvdeyen commented 6 days ago

What is this pull request for?

If the server responds with a 500 exception we already return a html page with error details. By wrapping it in a turbo-frame (read from the Headers) we get rid of the nasty "Content missing" error message from Turbo.

Checklist

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.96%. Comparing base (8114970) to head (db40047). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2949 +/- ## ======================================= Coverage 95.96% 95.96% ======================================= Files 232 232 Lines 6271 6273 +2 ======================================= + Hits 6018 6020 +2 Misses 253 253 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tvdeyen commented 6 days ago

I will add more error responses (401, 403) etc.