search

Alcidauk / CineLog

A fork of KinoLog Android app with some extra functionnalities
GNU General Public License v3.0
47 stars 15 forks source link

Wallpapers, movie information not shown after csv import #4

Closed Ollo1 closed 5 years ago

Ollo1 commented 5 years ago

CineLog v1.0 Android 8.0

After export and re-import of csv data the wallpapers and movie information is not shown and will not refresh after re-start of the application. Instead a generic icon is shown.

Alcidauk commented 5 years ago

Hi,

seems the import process is unable to put back data in db. Could you to attach the file you tried to import to this issue ?

For your information, I improved error messages at import time, it will be released soon.

Ollo1 commented 5 years ago

Thanks for the feedback. Attached you find the file. I renamed it to allow upload. import.txt

Alcidauk commented 5 years ago

Ok, got it. Thanks for the file.

The issue is due to date formatting, I need to fix it to avoid the issue. I'll do that quickly to prevent issues with import.

EDIT: my deduction wasn't correct, the date format seems to be ok. The issue happens when a film already exists in db and is reimported. My opinion is that a film that is already in the db shouldn't be reimported. For now, I'll avoid import of films that already exist in db. And I'll create later an override mode when importing reviews. Do you agree with that, or do you think it should work differently ?

Ollo1 commented 5 years ago

Yes this sound reasonable. However the behaviour described seems not to work. Please try this

  1. Have a number of films.
  2. Export
  3. Delete one film
  4. Import previous export. Deleted filmis back however all other as entries are remimported and leads to duplicates.

If I delete the database everthing including images is imported.

Alcidauk commented 5 years ago

I was waiting for your opinion before avoiding duplicates, so I didn't include it in v1.0.1.

I will do this as soon as possible. However, films without wallpaper and informations when reimporting data should be fixed, isn't it ?

Ollo1 commented 5 years ago

Sorry I misunderstood. But yes I agree on your proposal. I confirm the re-import worked without issue. Thanks.

Alcidauk commented 5 years ago

With the new release (v1.1), I improved the system. For now, all movies in the imported file ERASE movies that were in the db. In the next release, I'll add an option in the import view to avoid erasing movies if already existing.