search

Alcidauk / CineLog

A fork of KinoLog Android app with some extra functionnalities
GNU General Public License v3.0
49 stars 15 forks source link

Option to share tmdb link or name in case it's not from tmdb #65

Closed sbssk8 closed 7 months ago

sbssk8 commented 1 year ago

Hi! This is a draft version of a PR that allows sharing a link (or the name of the review or item on the wishlist in case it's not from tmdb).

I am not sure how to proceed with translations or if maybe adding another item to share the link with the review, the watching date and the rating.

Please let me know if you would like to merge, how to proceed with the translations (I just put added the ignore missing translations flag) and if there's any changes I could make.

BTW, thanks for the app, I've been using it for quite a while

(Maybe related with https://github.com/Alcidauk/CineLog/issues/28)

sbssk8 commented 1 year ago

Example of how it looks now:

4b802175-82e5-4fc3-ab70-653a1dd1db0f 53d89883-bfc1-4bf6-b2f1-d2d2c6508c0f

The shared link would be https://www.themoviedb.org/movie/343 in this case

Alcidauk commented 1 year ago

Hi,

I just saw your PR, thank you for this feature ! I'll add it to the next version I'll package (beta4).

Pierre

Alcidauk commented 7 months ago

Hi, :

I just worked on your PR. I did some small modifications, but nothing changes in UI.

For translations, I had a bad practice, until now (was adding english value in all languages). The flag you added is a much better solution, I let it as you made it.

I close this PR and merge the one I pushed (https://github.com/Alcidauk/CineLog/pull/78), coming from yours.

Thank you again,

Pierre