search

Aldaviva / WinampNowPlayingToFile

⚡ When Winamp plays a track, this plugin will save the track metadata and album art to files.
Apache License 2.0
17 stars 1 forks source link

Allow separate images when song has no album art vs. when no song is playing #13

Closed Aldaviva closed 1 year ago

Aldaviva commented 1 year ago

In #11, I made the plugin output the empty album art file (PNG in installation directory, falling back to 1x1px black PNG) when Winamp was stopped/paused/exit, not just when playing a song with no album art, so that OBS would stop complaining.

Users may want different images when the song has no album art compared to when Winamp is stopped. Currently, it is always the same emptyAlbumArt.png or 1×1 black PNG in both cases.

Version Playing with art Playing without art Stopped
≤ 1.1.0 Song art emptyAlbumArt.png, or black 1×1px Delete file
#11 Song art emptyAlbumArt.png, or black 1×1px emptyAlbumArt.png, or black 1×1px
Proposed #13 A Song art emptyAlbumArt.png, or black 1×1px stoppedAlbumArt.png or black 1×1px
Proposed #13 B Song art emptyAlbumArt.png, or black 1×1px stoppedAlbumArt.png or delete file
Proposed #13 C Song art emptyAlbumArt.png, or delete file stoppedAlbumArt.png or delete file

Another possibility not covered by this issue is restoring the ability to delete the output file when Winamp was stopped, as it did in 1.1.0. I'm not sure if this would be useful or desired. If so, it would probably be a boolean setting with a checkbox in the plugin settings UI backed by a registry value, similar to the other settings. It could also be opt-in by creating stopped.png, and if it's not there, fall back to the old behavior of deleting the file.

Aldaviva commented 1 year ago

Implemented proposal B, but unit tests are still needed.

Aldaviva commented 1 year ago

Figured out how to find the error message dialog box in unit tests, assert its text contents, and programmatically close it, increasing the test coverage.

Aldaviva commented 1 year ago

Released in 2.0.0.0.