Aldaviva / WinampNowPlayingToFile

⚡ When Winamp plays a track, this plugin will save the track metadata and album art to files.
Apache License 2.0
15 stars 1 forks source link

Album Art displaying back box after updating #9

Closed DougRedfield87 closed 1 year ago

DougRedfield87 commented 1 year ago

When I try to update album art for the now playing PNG to load them instead of showing the art it just displays a black box and i update the art in Winamp. how do i fix this so it will show all my album art after i update it?

Aldaviva commented 1 year ago

Hello @DougRedfield87,

When the song changes, this plugin uses TagLibSharp to extract the album art to a file. It's possible that there is some incompatibility with file types in TagLibSharp. For example, I seem to recall it not being able to extract album art from Ogg Vorbis files. Feel free to upload an affected audio file somewhere so I can try to reproduce the issue you're experiencing.

DougRedfield87 commented 1 year ago

how do i do there here? and the files i do use are MP3

Aldaviva commented 1 year ago

You should be able to drag and drop the MP3 file into the comment text box on this page and it will upload the file.

DougRedfield87 commented 1 year ago

Spider-Man and the X-Men in Arcade's Revenge Music- High Score Table.zip

Aldaviva commented 1 year ago

Thanks. Can you upload the album art PNG file as well? It looks like the above MP3 file does not have any album art in it currently.

DougRedfield87 commented 1 year ago

Spider-Man   The X-Men in Arcade's Revenge

Aldaviva commented 1 year ago

I was able to get a similar behavior to reproduce. When I used Winamp to set this MP3 file's album art to the above JPG image with File Info › Artwork › Load Artwork, it copied the JPG file to Spider-Man & The X-Men in Arcade's Revenge.jpg in the same folder as the MP3 file, rather than saving it into the MP3 file's ID3 metadata tags.

If you go into File Info › Artwork, can you check what the origin is for your album art? image

If you are able, can you also try embedding the album artwork into the MP3 file to make the origin say embedded, so that we can see if this is the problem? You may need to use a program like TagScanner or Mp3tag to do this.

Since WinampNowPlayingToFile only looks for album art in the media files' metadata, it could not find the artwork, but Winamp also looks for files matching certain names in the same folder as the media file when it is loading artwork. By trying a few common filenames, looking at the strings loaded into Winamp's memory, and monitoring filesystem activity, these seem to include

image

I haven't encountered this before because I almost always embed album art into my media files using TagScanner, because I wanted the artwork to sync to other destinations like my Android phone or YouTube Music, and my artwork usually isn't large enough for the disk savings of a common album art file to be worth it.

It may be possible to make WinampNowPlayingToFile's album art lookup work more like Winamp's, where it also checks for specifically-named files in the same folder as the media file.

DougRedfield87 commented 1 year ago

so I will try to do that with TagScanner to see if it will embed to it and see if it comes up

DougRedfield87 commented 1 year ago

so it looks like that was the fix to embed it into the file. Thanks again for the help!

Aldaviva commented 1 year ago

Great, glad we figured that out.

There may be a way to make TagScanner or Mp3tag bulk convert album art files into embedded metadata if that's something you want to pursue, I'm not sure.

I can probably also add a new feature to WinampNowPlayingToFile in the future to make its album art finding behave more like Winamp's, where it checks those other files in the same folder as the media file.

Aldaviva commented 1 year ago

The official Winamp forums have an incorrect lookup order for the album art that Winamp displays. Based on my own verification, the correct list is as follows.

  1. embedded
  2. %album%.bmp (where %album% is the song's album name from its file metadata)
  3. %album%.gif
  4. %album%.jpeg
  5. %album%.jpg
  6. %album%.png
  7. *.nfo (treat .nfo file basename as image basename, e.g foo.nfofoo.*foo.jpg)
  8. cover.bmp
  9. cover.gif
  10. cover.jpeg
  11. cover.jpg
  12. cover.png
  13. folder.bmp
  14. folder.gif
  15. folder.jpeg
  16. folder.jpg
  17. folder.png
  18. front.bmp
  19. front.gif
  20. front.jpeg
  21. front.jpg
  22. front.png
  23. albumart.bmp
  24. albumart.gif
  25. albumart.jpeg
  26. albumart.jpg
  27. albumart.png
Aldaviva commented 1 year ago

This development snapshot build should make WinampNowPlayingToFile use the same album art lookup algorithm as Winamp. It will search for external files like cover.jpg, and others from the priority list above, in the same directory as the media file.

You can try this out as an alternative to embedding your album art into all your media files.

WinampNowPlayingToFile.zip from build #10

This is working for me with a ripped FLAC album that has no embedded artwork, but does have a large scanned cover.jpg in the same folder.

Aldaviva commented 1 year ago

Released this fix in version 1.1.0.0.