Alderon-Games / pathoftitans-bugs

103 stars 46 forks source link

Iguanodon +Defense Subspecies is faster than Speed Sub & Bal Sub - Origin of Bug Located within Alioramus #13176

Closed WhyWatt closed 3 months ago

WhyWatt commented 3 months ago

Expected Behavior

Iguanodon's +Def,-Speed subspecies should be reflective of its curve-overrides, so on officials it would be slower than default by -5%

CurveOverrides=(CurveName="Iguanodon.Multiplier.BulkySubSpecies.Speed",Values=(0.95,0.95,0.95,0.95,0.95)) CurveOverrides=(CurveName="Iguanodon.Multiplier.BulkySubSpecies.IncomingDamage",Values=(0.9,0.9,0.9,0.9,0.9))

& likewise, if a server were to modify values, you would anticipate that it would be reflected in-game.

Current Behavior

Iguanodon's +Def,-Speed subspecies is 10% faster rather than 5% slower, on officials and singleplayer alike. However, changes to the override have no impact. They DO impact the Speed subspecies as normal.

This can be verified by using the /getattr movementspeedmultiplier command while playing as a +Def,-Speed Iguanodon.

On its own, the above only can confirm the existence of the bug, but what made me uniquely positioned to find the actual source of the bug, and by extent, fix, is how many curves I edit on my server... including most subspecies and passive effects. As such on my server, the bug was 5x more potent than on officials or singleplayer, making +Def,-Spe Iguanodon 1.5x faster than balanced, which naturally was horribly unbalanced and something I've spent several hours trying to get to the root-cause of.

At 1:25pm EST today, the 12th of June, I decided to try and find the true cause. At 3:49pm EST today, I found the origin of the bug.

My deduction started by an awareness that mods had nothing to do with the bug; the bug is present on officials after all, where no mods are, which narrowed down the sources of the bug.

I removed all custom lines of code surrounding Iguanodon, rebooted server, hopped on an Iguanodon and noted the bug's remained at 1.5x movement speed. Then, quite literally flipping a code, I removed the curve overrides for all official animals above Iguanodon alphabetically. The bug reverted to official/singleplayer 1.1x speed.

After this I checked the curve overrides for all the following animals, Achillobator Albertaceratops Alioramus Allosaurus Amargasaurus Anonodontosaurus Barsboldia Camptosaurus Ceratosaurus Concavenator Daspletosaurus Deinonychus Deinocheirus Eotriceratops

And checked for all lines my server had at 1.5 that are 1.1 in vanilla. Beginning from Eotriceratops and making my way up, I would re-implement the curve overrides, restart the server and check the speed in-server of my +Defense,-Speed Iguanodon.

When I reached Alioramus, Iguanodon returned to being ridiculously fast.

I found the origin of the bug is from the following: CurveOverrides=(CurveName="Alioramus.Multiplier.BulkySubSpecies.StaminaRecovery",Values=(1.5,1.5,1.5,1.5,1.5))

Which has default values of: CurveOverrides=(CurveName="Alioramus.Multiplier.BulkySubSpecies.StaminaRecovery",Values=(1.1,1.1,1.1,1.1,1.1))

Changing the values to: CurveOverrides=(CurveName="Alioramus.Multiplier.BulkySubSpecies.StaminaRecovery",Values=(0.95,0.95,0.95,0.95,0.95))

caused +Defense,-Speed Iguanodon's speed to reduce to 0.95x the value of Balanced.

I was also able to confirm that Alioramus' +Stamina Regen subspecies did see a loss in stamina regen after making these changes.

Reproduction Steps

1-Launch Singleplayer

1.1-Create an Iguanodon and make sure you are on the +Defense, -Speed subspecies, spawn in

2-Use /getattr MovementSpeedMultiplier

2.1-Note results will be 1.1

3-Exit out of the game

4-In the Game.ini of a server, place CurveOverrides=(CurveName="Alioramus.Multiplier.BulkySubSpecies.StaminaRecovery",Values=(0.95,0.95,0.95,0.95,0.95))

under the [/Script/PathOfTitans.IGameSession]

so that it looks like

[/Script/PathOfTitans.IGameSession] CurveOverrides=(CurveName="Alioramus.Multiplier.BulkySubSpecies.StaminaRecovery",Values=(0.95,0.95,0.95,0.95,0.95))

4.1-Save the Game.ini

4.2-Restart the server

5-Enter the server, create an Iguanodon make sure you are on the +Defense, -Speed subspecies, spawn in

Repeat step 2

6-Note the result will be 0.95 this time

Evidence

https://youtu.be/7s9wMqFHolM

(video is currently uploading, will be available shortly, ETA 15min @ June 12th 5 PM EST

Crash Logs

n/a

Build Information

Game Version: 0.0.0.32601-Shipping @ 5.3.2+ZEN

Operating System & Version: Microsoft Windows 11 Home / Version: 10.0.22631 Build 22631

Alderon Games ID: 842-623-710

AlderonEmu commented 3 months ago

Closing as this issue is known, or has already been reported. Thank you for your report nonetheless!