search

Aldlevine / comptroller

A simple and lightweight tool to manage your monorepo.
MIT License
28 stars 2 forks source link

When adding more detectives I can find dependencies, but they are not fully resolved #40

Closed kristianmandrup closed 6 years ago

kristianmandrup commented 6 years ago

How does the infrastructure work behind the hood?

Are the test even correct!?

For the fileStructure used you have a spelling error for source

// WORKS (guess the option is ignored)

"comptroller": {
  "srource": "index.js",
}

// FUCKS UP!
"comptroller": {
  "source": "index.js", // BREAKS!!
}

Also, my new detective infrastructure works, to find dependencies for these file/module types:

However, I can see that they are resolved just once, whereas the require are resolved deeply somehow... So there must be some other hard coding going on that is targeted specifically to CommonJS/node require. Please advice.

Please see: https://github.com/kristianmandrup/comptroller/tree/test

kristianmandrup commented 6 years ago

Finally figured it all out... had to change the source to a file glob instead or remove the option to have the defaults take over (or change the test to only test for the dependencies in the index.js file!)