search

AldoCompagnoni / popler_API

API to access the popler database
MIT License
0 stars 0 forks source link

strings have whitespace #5

Closed sckott closed 5 years ago

sckott commented 5 years ago

@AldoCompagnoni many strings in the database have whitespace around the meaningful characters e.g.,

" Heteromyoxyuris" " deserti"

it seems to mostly affect genus and species fields so far that I can tell

is this planned to be fixed? or maybe the whitespace is meaningful somehow?

AldoCompagnoni commented 5 years ago

This are mistakes in the original data, and potentially mistakes we have included. This is not useful, and I had rarely noticed it - but if in your experience it is a recurring problem, I will gladly fix it!

sckott commented 5 years ago

it's a problem becuase the user then has to put a space in their query, and they won't know when and when not to do that. e.g., for " Syphacia" they need to do

https://popler.space/search?proj_metadata_key=25&genus=%20Syphacia

%20 is the url encoded code for a space

instead of simply

https://popler.space/search?proj_metadata_key=25&genus=Syphacia

without the space

AldoCompagnoni commented 5 years ago

Good call, I need to fix this!

sckott commented 5 years ago

ok

AldoCompagnoni commented 5 years ago

I have removed white spaces for variables kingdom, phylum, clss, subclass, ordr, family, genus, species, and common_name!

sckott commented 5 years ago

cool. when you get me a new dump I can get it loaded in