search

Aldriana / ShadowCraft-Engine

Calculations backend for ShadowCraft, a WoW theorycraft project.
GNU Lesser General Public License v3.0
37 stars 22 forks source link

Proc Improvements #30

Closed raconzor closed 13 years ago

raconzor commented 14 years ago

Pulled old Procs class out into a separate file, renamed to ProcsList. Behavior similar, except 1 combined function call for stat procs, and testing if a proc is present returns False or the proc object. Proc objects also have an number of boolean functions you can use to check if the proc triggers on a given event. Refer to https://github.com/Aldriana/ShadowCraft-Engine/issues#issue/28 for more info on the problems-to-solve addressed here.

Aldriana commented 14 years ago

Almost anything that can proc off an attack can proc off a debuff application - any "melee or ranged attack" proc can. If it doesn't specify "crit" or "damage" it can usually proc off rupture application.

Aldriana commented 13 years ago

Well, if you want it all in one place, it could be moved to Procs, I suppose - that is, you just call Proc() and it figures out what properties to assign based on the name (and possibly additional arguments, as necessary - notably weapon speed for PPM weapon enchants). I'm just not a particular fan of needing to deepcopy it from someplace it will never be used directly.

raconzor commented 13 years ago

I'd say go ahead as-is.