search

Aldriana / ShadowCraft-Engine

Calculations backend for ShadowCraft, a WoW theorycraft project.
GNU Lesser General Public License v3.0
37 stars 22 forks source link

Level #36

Closed julienp closed 13 years ago

julienp commented 13 years ago

Changing level dependent values as discussed in https://github.com/Aldriana/ShadowCraft-Engine/issues#issue/21/comment/525445

test.py gives the same result, I've tested some variations of changing the level around, but there might be edge cases I missed. RogueDamageCalculator has some methods like sinister_strike_damage that aren't used by any tests yet, I don't think I missed something there, but it's certainly not impossible.

I took most of dazer's changes from https://github.com/Aldriana/ShadowCraft-Engine/pull/35

I ended up changing the dicts with the level info to lower case names, not sure why, but it looked better to me. If you prefer all class attributes to be in upper case I can change it back.

Aldriana commented 13 years ago

Generally looks good; just some minor syntax notes that I'll be posting shortly.

julienp commented 13 years ago

Hope I got everything, didn't have time to thoroughly check the changes. I'll review it later tonight again.

Aldriana commented 13 years ago

Okay. Do you want time to do that before I pull, or shall I take what's here?

julienp commented 13 years ago

I think you can just pull this as is, worst case there's an error in something for a lower level or unused by the assassination calculations.