Closed Aldriana closed 13 years ago
Couple questions: How many methods are we talking about? weapon stuff I think deserves its own one; as for the others (procs, gear buffs and activated abilities), one method can handle them all just fine. Where should weapon enchants go?
Procs: are we providing a list of the ones we want to check or should we simply take every single proc available?. Taking each and every single one available now may be usefull, but the list will indubitably grow as patches go by (and potentially with more classes adhering to our cause).
Weapon damage: I take it we should measure increases in dps (for each weapon) as that's the value that changes smoothly for every kind of weapon with each tier of gear.
Weapon speed: I'm kind of lost here so I'll leave it for later, once I figure what do I want to do in this area.
For procs, gear buffs, etc. I'd probably take an input list of ones to return EP values for and return a dictionary of proc: value pairs.
For weapons, beyond the obvious needs of weapon DPS EP values, we'll want some manner of speed EP values - the solution here might be again just passing in which speeds you want values for, as its very different by spec. Historically we've also needed EP values by type of weapon, but I don't see that that's particularly relevant as there aren't substantive choices. When and if they make fast nondagger weapons so we need to consider the effect on OHs we'll worry about that; in general I think we can ignore it for the moment.
Weapon enchants are sort of up to you. I can see doing them under either procs or weapons, or as their own thing, so... no strong recommendation.
Basically, I don't have this feature strongly mapped out in my mind - I'd just like the ability to make meaningful comparisons between options without needing to manually compute the DPS for every one of them. So do whatever you think is best.
So, right now we have EP values for the basic gear stats; however, for gear comparisons its sometimes useful to assign EP values to other stats, such as: weapon speed, weapon damage, trinket procs, passive bonuses (i.e. metagem bonuses) and the like. Hence, we should think about adding a second EP function to calculate these slightly more obscure quantities.
To be clear: I think the existing function should stay with what it has, and we should add this new function in addition to that.