search

Aldriana / ShadowCraft-Engine

Calculations backend for ShadowCraft, a WoW theorycraft project.
GNU Lesser General Public License v3.0
37 stars 22 forks source link

Improved Racials Handling #60

Closed Aldriana closed 13 years ago

Aldriana commented 13 years ago

It seems like most of the racials can be tied into the existing framework(s) we have; for instance, we could have the Worgen racial be detected automatically in the crit calculations, create a wrapper function in the calculator that pulls in both gear buffs and activated racial abilities so they can be iterated through in a single call, and so forth. Basically: we're already handling the expertise racials automatically without the modeler needing to do anything; it would be good to see how many of the others we can do the same way.

raconzor commented 13 years ago

Working on this, will probably submit pull request tomorrow night. Do you want all of the (set) racials to be returned by this function, or only the ones that affect a stat directly (orc only, others are damage, haste multiplier, energy return). Adding the tests for my changes as I go.

raconzor commented 13 years ago

Also adding a racial haste function to support goblins ... looks like haste is currently only really used in your calculator so I guess I'll leave where to use that up to you.

Aldriana commented 13 years ago

Hmm, I guess there's less to do here than I thought. The troll/goblin/blood elf racials will indeed need to be handled in the model, so I guess this is mostly just getting the orc AP bonus to demonstrate the proper level-dependency and be callable somewhere, and having the crit functions handle the worgen racial.

Aldriana commented 13 years ago

Think this is basically done at this point. Closing.